Skip to content

Conversation

@spiridonov
Copy link
Contributor

@spiridonov spiridonov commented Nov 20, 2025

What this PR does / why we need it:

I tweaked few things to match behavior of the old engine:

  • For unwrap. It turns a column in to numerical value, but the original string column should be dropped.
  • For range aggregations: it should not count rows with errors from parsing json/logfmt or unwrap, so those rows are filtered out.
  • The old implementation of logfmt does not return error columns.

Those tweaks are added as simple nodes in the physical plan in order to not contaminate the logic of other relevant nodes.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant