Skip to content

Create Plugin: Support Node 24 #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 14, 2025
Merged

Create Plugin: Support Node 24 #1772

merged 7 commits into from
May 14, 2025

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented May 7, 2025 •
edited by grafana-plugins-platform-bot bot
Loading

What this PR does / why we need it:
We need to support latest versions of node.

Which issue(s) this PR fixes:

Fixes #1771
Related #1664

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]

@jackw jackw requested review from a team as code owners May 7, 2025 05:29
@jackw jackw requested review from Ukochka and wbrowne May 7, 2025 05:29
@jackw jackw requested review from andresmgot and xnyo May 7, 2025 05:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@jackw jackw marked this pull request as draft May 7, 2025 05:29
@jackw jackw changed the title Create Plugin: Support Node 24 [WIP] Create Plugin: Support Node 24 May 7, 2025
@jackw jackw self-assigned this May 7, 2025
@jackw jackw added create-plugin related to the create-plugin tool sign-plugin Changes related to sign-plugin no-changelog Don't include in changelog and version calculations labels May 7, 2025
@jackw jackw force-pushed the jackw/support-future-node branch from 88f59be to 7bbc14c Compare May 7, 2025 05:44
@tolzhabayev tolzhabayev moved this from 📬 Triage to 🧑‍💻 In development in Plugins Platform / Grafana Community May 7, 2025
@jackw jackw force-pushed the jackw/support-future-node branch 2 times, most recently from 3eeb604 to 29c9002 Compare May 8, 2025 11:09
@jackw jackw changed the title [WIP] Create Plugin: Support Node 24 Create Plugin: Support Node 24 May 8, 2025
@jackw jackw marked this pull request as ready for review May 8, 2025 13:19
@jackw jackw added minor Increment the minor version when merged release Create a release when this pr is merged and removed sign-plugin Changes related to sign-plugin no-changelog Don't include in changelog and version calculations labels May 8, 2025
@jackw jackw force-pushed the jackw/support-future-node branch from 9af6b89 to 18d5226 Compare May 8, 2025 13:49
@tolzhabayev
Copy link
Collaborator

Once merged and released notify / close #1664

@github-project-automation github-project-automation bot moved this from 🧑‍💻 In development to 🔬 In review in Plugins Platform / Grafana Community May 13, 2025
@jackw jackw force-pushed the jackw/support-future-node branch from 18d5226 to 888ff66 Compare May 14, 2025 05:37
academo
academo approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@academo academo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally (using the canary release) and it works as expected (tested with node 22 and node 24)

@jackw jackw merged commit 4bce9dd into main May 14, 2025
24 checks passed
@jackw jackw deleted the jackw/support-future-node branch May 14, 2025 07:37
@github-project-automation github-project-automation bot moved this from 🔬 In review to 🚀 Shipped in Plugins Platform / Grafana Community May 14, 2025
@grafana-plugins-platform-bot
Copy link

🚀 PR was released in @grafana/[email protected], @grafana/[email protected] 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label May 14, 2025
@jackw jackw mentioned this pull request May 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@academo academo academo approved these changes

@hugohaggmark hugohaggmark hugohaggmark approved these changes

@Ukochka Ukochka Awaiting requested review from Ukochka Ukochka is a code owner automatically assigned from grafana/plugins-platform-frontend

@wbrowne wbrowne Awaiting requested review from wbrowne wbrowne is a code owner automatically assigned from grafana/plugins-platform-backend

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-backend

@xnyo xnyo Awaiting requested review from xnyo xnyo is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees

@jackw jackw

Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
Plugins Platform / Grafana Community
Status: 🚀 Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Support Node 24
4 participants
@jackw @tolzhabayev @academo @hugohaggmark