Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pySigma to 0.11.19 #196

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Update pySigma to 0.11.19 #196

merged 6 commits into from
Jan 27, 2025

Conversation

kelnage
Copy link
Collaborator

@kelnage kelnage commented Jan 20, 2025

This fixes #192, enabling correlation queries to be converted once again. Also includes updating the build environment to use Python 3.9 and higher, in accordance with pySigma.

@kelnage kelnage requested a review from a team as a code owner January 20, 2025 11:50
@kelnage kelnage linked an issue Jan 20, 2025 that may be closed by this pull request
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12867380595

Details

  • 28 of 30 (93.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 98.492%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sigma/backends/loki/loki.py 28 30 93.33%
Totals Coverage Status
Change from base Build 12584204270: -0.2%
Covered Lines: 653
Relevant Lines: 663

💛 - Coveralls

Copy link
Collaborator

@jamesc-grafana jamesc-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelnage kelnage merged commit b20516c into main Jan 27, 2025
13 checks passed
@kelnage kelnage deleted the update-pySigma-0.11.19 branch January 27, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix conversion of Correlation rules in pySigma v0.11.18
3 participants