-
Notifications
You must be signed in to change notification settings - Fork 47
chore!: update peer dependencies of scenes packages #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
think these are to lax, latest scenes lib requires at least 11.3 or 11.4 |
It looks like the latest scenes lib is still requiring 10.4: scenes/packages/scenes/package.json Lines 50 to 60 in a2a3709
We could switch both to |
yea, we need to update those as well |
I've updated the scenes/packages/scenes/src/core/SceneTimeRange.test.tsx Lines 406 to 420 in 2b66598
I'll revisit this with fresh eyes. |
Motivation
The motivation is two-fold:
Friction installing
@grafana/scenes-react
In projects that use version
12.x
of@grafana/data
,@grafana/runtime
, etc.,@grafana/scenes-react
cannot be installed due to conflicting peer dependencies:Alignment with Grafana support schedule
https://grafana.com/docs/grafana/latest/upgrade-guide/when-to-upgrade/#what-to-know-about-version-support describes Grafana's support schedule. The peer dependencies in
@grafana/scenes
and@grafana/scenes-react
use versions of@grafana/<some-core-package>
that are no longer supported. This is an opportunity to align Scenes packages with the broader support schedule.What's changed?
This PR updates
@grafana/*
peer dependencies to "at least 11.6" in@grafana/scenes
and@grafana-scenes-react
. In@grafana/scenes
, this means dropping support for 10.x. In@grafana/scenes-react
, this change is less restrictive, requiring a minimum version of11.6.x
but allowing, for example,12.1.0
. This aligns@grafana/scenes-react
with the peerDep version pattern used by@grafana/scenes
.