Variables: Support for object values / multiple value properties #1228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I explored variables with many "value properties" first in #995 . The thing that troubled me is that the natural continuation for that is to support it for Query variables as well, and from a user perspective building a dashboard it becomes very muddy/confusing to introduce basically identical variable types with the only difference being one support values with many properties.
The same problem exists for #1228 when we want to introduce it to dashboards (and build on it to support object values for variable queries)
In this PR I am taking the first step in supporting "object" / multi property values in MultiValueVariable. Which required a very small change.
Next I would explore
^ I am not doing this in the next week or so, anyone who has time could start exploring the above.
Open question