SceneAppPage: Page background option #1247
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem)
There has been a long-standing inconsistency in page designs / main background. Between pages that use the
canvas
background (Dashboard, Explore, Drilldown) and all other pages that use theprimary
background.Most or all of the scene apps on cloud (o11y, frontend o11y, kubernetes app, and others) use
primary
background but look very much like dashboards (but with tabs). For more on this specific problem, there is this doc I wrote a long time agoI have tried many many times to solve this inconcisteny over past 3 years.
But none of my attempts to solve it have looked great. Before summer I stumbled on this solution of embracing this inconsistency rather than trying to get rid of it. So this it was this PR proposes.
This adds a new background option to SceneAppPage and SceneApp (can set a default for the whole app). OSS PR: grafana/grafana#111174