SceneTimeRangeCompare: Fix url syncing #1277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew08t
added
release
torkelo
reviewed
Oct 16, 2025
| compareWith?: string; | ||
| compareOptions: Array<{ label: string; value: string }>; | ||
| hideCheckbox?: boolean; | ||
| key?: string; |
There was a problem hiding this comment.
key is already a used state property that has specific meaning/usage.
torkelo
reviewed
Oct 16, 2025
Comment on lines
+166
to
+167
| const key = this.state.key || 'compareWith'; | ||
| return { [key]: this.state.compareWith }; |
There was a problem hiding this comment.
why this change? the UrlSyncManager and UniqueUrlKeyMapper should already handle making url keys unique for the scene, might be some bug there we can fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the url syncing for time comparison during page refresh by inputting an option key (to be passed by the panel to include
compareWith-[panel id]Before:
After:
Fixes grafana/grafana#112274