Filters: Add per-panel non-applicable pills #1278
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mdvictor
added
minor
mdvictor
requested review from
dprokop,
harisrozajac,
ivanortegaalba and
torkelo
dprokop
reviewed
Oct 20, 2025
There was a problem hiding this comment.
LGTM, please consider my feedback in grafana/grafana#112507
| /** | ||
| * Allows adding elements to the subheader of the panel. | ||
| */ | ||
| subHeaderContent?: React.ReactNode | SceneObject | SceneObject[]; |
There was a problem hiding this comment.
nit
Suggested change
| subHeaderContent?: React.ReactNode | SceneObject | SceneObject[]; | |
| subHeader?: React.ReactNode | SceneObject | SceneObject[]; |
dprokop
approved these changes
Oct 20, 2025
|
Thank you @dprokop! I'll tackle the core PR and update based on review, thank you for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the vizPanel with a subHeader row in which various elements can be shown. This is in preparation to showing non applicable filter pills in there. Depends on PanelChrome to render the subHeader
📦 Published PR as canary version:
6.40.0--canary.1278.18560955561.0✨ Test out this PR locally via: