Skip to content

fix(reusable-zizmor): skip empty ZIZMOR_CONFIG variable #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(reusable-zizmor): skip empty ZIZMOR_CONFIG variable #1102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions .github/workflows/reusable-zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,16 +379,18 @@ jobs:
ZIZMOR_CONFIG: ${{ steps.setup-config.outputs.zizmor-config }}
ZIZMOR_CACHE_DIR: ${{ runner.temp }}/.cache/zizmor
shell: sh
run: >-
uvx zizmor@"${ZIZMOR_VERSION}"
--format sarif
--min-severity "${MIN_SEVERITY}"
--min-confidence "${MIN_CONFIDENCE}"
--cache-dir "${ZIZMOR_CACHE_DIR}"
${ZIZMOR_CONFIG:+--config "${ZIZMOR_CONFIG}"}
${RUNNER_DEBUG:+"--verbose"}
${ZIZMOR_EXTRA_ARGS:+${ZIZMOR_EXTRA_ARGS}}
.
run: |
if [ -z "${ZIZMOR_CONFIG}" ]; then
unset ZIZMOR_CONFIG
fi
uvx zizmor@"${ZIZMOR_VERSION}" \
--format sarif \
--min-severity "${MIN_SEVERITY}" \
--min-confidence "${MIN_CONFIDENCE}" \
--cache-dir "${ZIZMOR_CACHE_DIR}" \
${RUNNER_DEBUG:+"--verbose"} \
${ZIZMOR_EXTRA_ARGS:+${ZIZMOR_EXTRA_ARGS}} \
. \
> results.sarif

- name: Upload artifact
Expand Down Expand Up @@ -419,13 +421,15 @@ jobs:
# don't fail the build if zizmor fails - we want to capture the output
# and the exit code
set +e
if [ -z "${ZIZMOR_CONFIG}" ]; then
unset ZIZMOR_CONFIG
fi
uvx zizmor@"${ZIZMOR_VERSION}" \
--format plain \
--min-severity "${MIN_SEVERITY}" \
--min-confidence "${MIN_CONFIDENCE}" \
--cache-dir "${ZIZMOR_CACHE_DIR}" \
${RUNNER_DEBUG:+"--verbose"} \
${ZIZMOR_CONFIG:+--config "${ZIZMOR_CONFIG}"} \
${ZIZMOR_EXTRA_ARGS:+${ZIZMOR_EXTRA_ARGS}} \
. \
| tee -a "${GITHUB_OUTPUT}"
Expand Down
Loading