emoji default for House Timeline Gramplet #664
Conversation
Add "Emoji" house optionand make default Improve horizontal line from "equals" symbol to horizontal bar Increase font from 9pt to 12pt
Please don't , the current default is best! Also keep the font the same size please! |
No "Emoji" please!
make that optional!
It would be better if the addon used the font size from the Themes addon and left the font size alone! |
|
Options would seem to be the way forward here. You should be able to use the application font and just change it to a monospaced alternative (e.g. Courier) keeping the size the same. If you want to offer font size options then "smaller" and "larger" are possible. |
|
Well... I was able to do such a minor tweak how to add the emoji Configure option. And could re-submit just that as the change. (Without changing the default text "house" of default hard-coded font size and font family.) But it is beyond me to make it :
I just felt that the current defaults make it look primitive (like a 1970s terminal or line printer output). Also, 9pt is too hard to read for my old, weak eyes. And a default that adds hundreds of multi-line chunks of tediously repetitive data instead of hundreds of single lines for an (equally tedious and repetitive) emoji (or horizontal rules) seems wrong. Perhaps it would be possible to use the monospace font for JUST the text character house and have the rest be a proportional font? It would be a good experiment and demonstrate coding that might be adaptable elsewhere. (Like the Pedigree gramplet... where mixing font family stylings on a line could enhance the appearance and clipboarded data. Monospace the flowchart symbols, Proportional for the name display format, smaller for the vital statistics dates. Having the stylings clipboarded for pasting into a word processing document or reuse in a report variant would add to its usefulness.) |
|
Assuming this should be cherry-picked to gramps60 - |
|
Lets not cherry pick this one. Too much opposition. Maybe I should just flush the defaults changes and resubmit. Someone else will have to figure out the Themes (font size, font family) compatibility. |
|
Sorry for the confusion. I meant, if this PR is approved for gramps52, it should be cherrypicked to gramps60. In this case, the PR should fix the gramps60 bug. |
|
No problem. I would've already stripped out the defaults changes from the PR if I knew how. Then it COULD have been approved for 5.2 and cherry-picked for 6.0 But the best I (may) have time to do is cancel the PR and resubmit with adding emoji as a new option and replacing the divider character. |
remove changes to defaults that were controversial
I am surprised that this helps for the console warning message |
|
Sorry for the confusion. I did not mean to say that you fixed this bug. I only meant to see if fixing this 6.0 issue would be in-scope for this PR as it touches this code. That would allow cherry picking the 5.2 change to the 6.0 branch too. |
|
should be ready to merge now. The defaults are now the same was before. |
|
Merging to 5.2 branch. Not cherry picking to 6.0 branch. |
Add "Emoji" house option and make default
Improve divider from "equals" symbol to horizontal bar
Increase Courier font from 9pt to 12pt