Skip to content

fix(docker-entrypoint): startup with new search index for all existing trees #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

genofire
Copy link

@genofire genofire commented Aug 7, 2024

fix #531 and #510

@DavidMStraub
Copy link
Member

But you're now creating search indexes for all existing trees even if you're spinning up a local single-tree instance to play around.

I think the better solution would be to just gracefully ignore the failing command (without specifying tree) in case of a multi-tree deployment, and document that search indexing must be triggered manually on demand (via API, UI, or command line).

@genofire
Copy link
Author

genofire commented Aug 9, 2024

based on #533 it would work for both single and multi tree, now.

@DavidMStraub
Copy link
Member

I removed the search indexing from the entrypoint now so this is no longer needed. Thanks for bringing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Startup with MULTI_TREE is broken in New Search
2 participants