Skip to content

Add python 3 support#220

Open
vetal4444 wants to merge 21 commits intograngier:developfrom
vetal4444:python_3
Open

Add python 3 support#220
vetal4444 wants to merge 21 commits intograngier:developfrom
vetal4444:python_3

Conversation

@vetal4444
Copy link
Copy Markdown

If you run goose under python bs3 parser will not be able to use.

@hnykda
Copy link
Copy Markdown

hnykda commented Jul 8, 2015

When we can expect that this will be merged?

@xanderdunn
Copy link
Copy Markdown

+1 for merging

@Tomtomgo
Copy link
Copy Markdown

Tomtomgo commented Oct 4, 2015

+1

@Daenyth
Copy link
Copy Markdown

Daenyth commented Dec 11, 2015

ping @grangier

@hnykda
Copy link
Copy Markdown

hnykda commented Dec 11, 2015

Is there any problem with this PR? Can we help somehow or you are just ignoring it?

@thelonecabbage
Copy link
Copy Markdown

@grangier +1

Lol4t0 pushed a commit to Lol4t0/python-goose that referenced this pull request Jan 11, 2016
cssselect
jieba
beautifulsoup
beautifulsoup # Only on python2
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so your code will not work in python 3?

cssselect
jieba
beautifulsoup
beautifulsoup # Only on python2
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working in python 3.5.4 as it does not support beautifulsoup. Even after changing the requires.txt with beautidulsoup4 the install didnt work. Attached error file
error_goose_extract.txt

@gaussic
Copy link
Copy Markdown

gaussic commented May 8, 2018

Waiting for so long!!!

@hnykda
Copy link
Copy Markdown

hnykda commented May 8, 2018

@gaussic You actually wait for it? This project is 3 years dead. There is plethora of better solutions already, such as https://github.com/goose3/goose3 or https://github.com/codelucas/newspaper

@amirouche
Copy link
Copy Markdown

Thanks but newspaper doesn't work that well AFAIK

@amirouche
Copy link
Copy Markdown

Why are people still using beautiful soup in 2018?

@gaussic
Copy link
Copy Markdown

gaussic commented May 9, 2018

@hnykda Great, thanks man. By the way, @amirouche I'm still using BeautifulSoup 4 and it's easy to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants