fix(gwr-perfetto-sys,gwr-perfetto): always dirty during incremental builds #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilds Incremental builds were not working optimally for dependants of gwr-perfetto-sys, resulting in slower incremental builds. To resolve this issue, and to ensure that these packages will work as intended when used from crates.io,the `gwr-perfetto-sys/perfetto` symlink has been replaced with the `PERFETTO_SOURCE` const now published by the gwr-perfetto-sys library. Incremental builds now work as expected, however it is worth noting that if files within the gwr-perfetto-sys or gwr-perfetto packages are touched in between incremental builds they may continue to appear dirty until the next clean when running `cargo check`.
samchesney
force-pushed
the
fix-perfetto-incremental
branch
from
bd2e6cd to
ea49d64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental builds were not working optimally for dependants of
gwr-perfetto-sys, resulting in slower incremental builds.
To resolve this issue, and to ensure that these packages will work as
intended when used from crates.io,the
gwr-perfetto-sys/perfettosymlinkhas been replaced with the
PERFETTO_SOURCEconst now published by thegwr-perfetto-sys library.
Incremental builds now work as expected, however it is worth noting that
if files within the gwr-perfetto-sys or gwr-perfetto packages are
touched in between incremental builds they may continue to appear dirty
until the next clean when running
cargo check.