Skip to content

simplify-inflection: duplicate fields bug #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maximsmol wants to merge 4 commits into
base: main
Choose a base branch
from
+2,305 −2
Open

simplify-inflection: duplicate fields bug #3027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a89bf58
simplify-inflection: duplicate fields bug
maximsmol Apr 10, 2026
3095c4b
simplify-inflection: fix duplicate names on singleRelationBackwards
maximsmol Apr 10, 2026
69e3736
simplify: add pair_skating test
maximsmol Apr 13, 2026
819fab3
simplify: update skaters test
maximsmol Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions graphile-build/graphile-simplify-inflection/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ const PgSimplifyInflectionPlugin: GraphileConfig.Plugin = {
).find((u) => u.isPrimary);
if (
foreignPk &&
arraysMatch(foreignPk.attributes, relation.remoteAttributes)
arraysMatch(foreignPk.attributes, relation.localAttributes)
) {
return this.camelCase(
`${this._singularizedCodecName(relation.remoteResource.codec)}`,
Expand Down Expand Up @@ -387,7 +387,7 @@ const PgSimplifyInflectionPlugin: GraphileConfig.Plugin = {
const uniques = (possibleResources[0]?.uniques ??
[]) as PgResourceUnique[];
const pk = uniques.find((u) => u.isPrimary);
if (pk && arraysMatch(pk.attributes, relation.localAttributes)) {
if (pk && arraysMatch(pk.attributes, relation.remoteAttributes)) {
return this.camelCase(
`${this._singularizedCodecName(relation.remoteResource.codec)}`,
);
Expand Down
Loading
Loading