Skip to content

Update dependencies + clean up #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benface
Copy link
Contributor

@benface benface commented Apr 7, 2025

This PR:

  • Updates dependencies, including @edgeandnode/go to have the latest NetworkIcon component.
  • Temporarily hides Ultra from the supported networks grid on the home page since web3icons doesn't support it yet.
  • Makes supported networks clickable on the home page.
  • Slightly improves the performance of searching for a network on the Supported Networks page, by debouncing the value.
  • Attempts to remove complexity in the code by removing unused code (e.g. SkeletonRow) and merging files together, increasing colocation and removing the need to name things in a similar and potentially confusing manner (e.g. NetworkPage and NetworkDetailsPage, or NetworksTable and SupportedNetworksTable).
  • Groups the scripts that should be run together in CI into a single prebuild:ci script. This can also be run locally, but the resulting changes (if any) should not be committed.

@benface benface requested a review from a team as a code owner April 7, 2025 19:05
@benface benface requested review from hayderkg and 0xa3k5 April 7, 2025 19:08
@0xa3k5
Copy link
Member

0xa3k5 commented Apr 7, 2025

I just added ultra to web3icons, and opened a pr to networks-registry (turns out ronin was also missing an icon)

)
.filter((network) => {
return (
// TODO: Fix Zora mono logo in web3icons
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this cannot be "fixed" unless zora decides to gives us a mono logo, we should just delete this todo imo

Comment on lines +156 to +157
// TODO: Add support for Ultra in web3icons and `NetworkIcon`
network.id !== 'ultra'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: Add support for Ultra in web3icons and `NetworkIcon`
network.id !== 'ultra'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants