Implement client keep-alives watchdog for graphql-transport-ws protocol in juniper_graphql_ws crate#1367
Merged
tyranron merged 15 commits intographql-rust:masterfrom Mar 9, 2026
Merged
Conversation
…ocol in `juniper_graphql_ws` crate
Contributor
Author
FCMImplement client keep-alives watchdog for `graphql-transport-ws` protocol in `juniper_graphql_ws` crate (#1367) |
tyranron
added
k::api
# Conflicts: # juniper_graphql_ws/CHANGELOG.md
tyranron
requested changes
Mar 8, 2026
# Conflicts: # juniper_graphql_ws/CHANGELOG.md
…live-watchdog # Conflicts: # juniper_graphql_ws/CHANGELOG.md
# Conflicts: # juniper_graphql_ws/CHANGELOG.md
tyranron
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synopsis
Current
graphql-transport-wsimplementation unable to properly detect client's connection lost (for example if client's unplug power/internet cable). For now it relying on TCP stream's connection lost detection, which has about ~15min timeout duration.Solution
This PR extends server's keep-alive machinery in
graphql-transport-wsprotocol implementation to require client to sendPings within specifiedkeep_alive_interval. If client's ping not received within specified interval then connection considered as lost.Checklist