LSP Rewrite Step 2: refactor for @graphql-tools#3556
Draft
Conversation
|
@graphql-tools@graphql-tools
a608668 to
7839f79
Compare
e8654b6 to
76c0d91
Compare
f24bb65 to
ea57543
Compare
0496caa to
203a2c0
Compare
fb7d418 to
e5ab31e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this gets us most of the way, just one integration suite assertion failing and some ts bugs. it needs a lot more work to be ready. the preceeding PR happens first of course
one of the end goals of this PR is also network schema invalidation :)) yes that's right, code first for all!
this also sets us up nicely for adding multi-root workspaces support, as we are reducing CPU and memory usage heavily in this PR, and this also provides a cleaner interface for MessageProcessor to support it
TODO: