Restrict AutoUpdateVersion to be created/updated for cloud #49008
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vapopov
added
the
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
zmb3
reviewed
Nov 14, 2024
| @@ -331,7 +332,7 @@ func GetModules() Modules { | |||
| var ErrCannotDisableSecondFactor = errors.New("cannot disable multi-factor authentication") | |||
|
|
|||
| // ValidateResource performs additional resource checks. | |||
| func ValidateResource(res types.Resource) error { | |||
| func ValidateResource(res any) error { | |||
There was a problem hiding this comment.
Is there any reason that AutoUpdateVersion can't implement types.Resource?
There was a problem hiding this comment.
new resources implements types.Resource153 they not compatible with each other
There was a problem hiding this comment.
Perhaps ValidateResource is trying to be too generic. Is there any reason this validation can't be applied directly within the auto update service instead?
|
If I understand correctly, this will render any version invalid on cloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR added validation to restrict modify
AutoUpdateVersionfor cloud usersRelated:
teleport/rfd/0144-client-tools-updates.md
Lines 216 to 224 in c906170