fix(typechecker): validate arrays.reduce callback return type matches accumulator (#2241) - #2251
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2241
arrays.reduce()was missing validation that the reducer callback's return type matches the accumulator type. When a callback returned a different type (e.g.,stringinstead ofint), the typechecker accepted it and codegen produced code that reinterpreted the return value's bits as the accumulator type, resulting in garbage data at runtime.Added an
else ifbranch in the existing reduce callback validation (E9004) that resolves the initial value's type and compares it against the callback's return type, emitting E9004 on mismatch.Added fail test
E9004_arrays_reduce_wrong_return.gray.