Add state based invariant checks #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
December 30, 2022 20:03
…ory AggregateRoot
…r to ensure there will always be a MaxQty
… than available count
|
Next time please collapse commits (easier to review). As reference, you can do this using git rebase -i HEAD~N Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an example of a state-based business invariant check as in issue #15 . It adds a 'hydrated' MaxQty property that Check Ins can be compared against. It also made sense to move the ephemeral 'count' property that didn't really exist in the abstration but was just passed around as an argument and was actually changed in the read model. It seemed to make much more sense to put it in the Inventory Aggregate as an actual property.