support inline display of the dialog#100
Open
tomasc wants to merge 6 commits intogregschmit:masterfrom
Open
Conversation
Author
|
any chance to have this merged? |
no need for click when we have tap?
|
This would be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We wanted to display the recurring select dialog inline (below the select input), so we customised your plugin as follows.
The inline display can be specified using data attribute on the input:
A position class (either
fixedorinline) is added to the. rs_dialog_holderelement and the css now supports the two options.We also adjusted the
recurring_select_dialog.js.coffee.erbso that when inline:Mainly, these changes do not break existing configurations.