[feat] Display connection-name when connected to ethernet#2150
Open
vatsalkeshav wants to merge 7 commits into
Open
[feat] Display connection-name when connected to ethernet#2150vatsalkeshav wants to merge 7 commits into
connection-name when connected to ethernet#2150vatsalkeshav wants to merge 7 commits into
Conversation
Contributor
Author
|
Implementation of MAC address as |
bim9262
requested changes
Mar 7, 2026
Collaborator
bim9262
left a comment
There was a problem hiding this comment.
Not all systems use NetworkManager. This change will cause an error to be thrown on those systems.
Contributor
Author
|
Hi, Also added a systemd-networkd fallback in case NM is not there - which tries NM first, then queries Tested both paths on an orbstack ubuntu 22.04 VM running on mac m1 (it has systemd 249, systemd-networkd managing eth0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds functionality to get and display the
connection_namefor wired connection as set byNetworkManagerasethernet_idalong with its icon.Should solve issue 1851