Skip to content

[feat] Display connection-name when connected to ethernet#2150

Open
vatsalkeshav wants to merge 7 commits into
greshake:masterfrom
vatsalkeshav:wired
Open

[feat] Display connection-name when connected to ethernet#2150
vatsalkeshav wants to merge 7 commits into
greshake:masterfrom
vatsalkeshav:wired

Conversation

@vatsalkeshav
Copy link
Copy Markdown
Contributor

@vatsalkeshav vatsalkeshav commented Mar 22, 2025

This pr adds functionality to get and display the connection_name for wired connection as set by NetworkManager as ethernet_id along with its icon.
Should solve issue 1851

@vatsalkeshav
Copy link
Copy Markdown
Contributor Author

Implementation of MAC address as ethernet_id could also be done if that'd help

Copy link
Copy Markdown
Collaborator

@bim9262 bim9262 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all systems use NetworkManager. This change will cause an error to be thrown on those systems.

@vatsalkeshav
Copy link
Copy Markdown
Contributor Author

vatsalkeshav commented Mar 18, 2026

Hi,
(post rebase)I've fixed the NetworkManager d-bus calls to gracefully return none on systems without NM

Also added a systemd-networkd fallback in case NM is not there - which tries NM first, then queries org.freedesktop.network1 via d bus( also with a Describe method fallback for older systemd <250 where the NetworkFile property isn't exposed) - also returns none in case that's present neither

Tested both paths on an orbstack ubuntu 22.04 VM running on mac m1 (it has systemd 249, systemd-networkd managing eth0

@vatsalkeshav vatsalkeshav requested a review from bim9262 March 18, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants