Expand xresources color support#2234
Open
bim9262 wants to merge 1 commit into
Open
Conversation
bim9262
force-pushed
the
xresources_rgb
branch
from
08d6194 to
66f8edc
Compare
As observed in greshake#2230: > I found https://man.archlinux.org/man/X.7#COLOR_NAMES and it looks > like #RRGGBB is one of several deprecated formats for specifying a > color. I can't tell about the case, though. We allow 6-8 characters > though, when it looks like it should be 3, 6, 9, or 12 nibbles. > However I think we can only use 6 characters (and that we shouldn't > accept 8 characters (#RRGGBBAA) as alpha is not allowed and it could be > a substring of #RRRGGGBBB or #RRRRGGGGBBBB.) > We could allow converting up #RGB to #R0G0B0 as X would do though. This removes the support for #RRGGBBAA format, while allowing for using `#define`s, `rgb:<r>/<g>/<b>`, `rgbi:<r>/<g>/<b>`, as well as colors defined in `rgb.txt`. This does not support processing `#include`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As observed in #2230:
This removes the support for #RRGGBBAA format, while allowing for using
#defines,rgb:<r>/<g>/<b>,rgbi:<r>/<g>/<b>, as well as colors defined inrgb.txt.This does not support processing
#include.