net block: allow defining absolute up and down bandwidth#2273
Open
GRBurst wants to merge 5 commits into
Open
Conversation
Signed-off-by: GRBurst <GRBurst@protonmail.com>
Signed-off-by: GRBurst <GRBurst@protonmail.com>
Signed-off-by: GRBurst <GRBurst@protonmail.com>
Signed-off-by: GRBurst <GRBurst@protonmail.com>
Signed-off-by: GRBurst <GRBurst@protonmail.com>
Collaborator
|
This sounds like it could be a nice option to have. Some users might be more interested in local network speeds so perhaps in that case it can default to the link speed? |
ammgws
reviewed
May 1, 2026
| "device" => Value::text(device.iface.name), | ||
| }); | ||
|
|
||
| if speed_down / max_network_speeds.down > 0.8 || speed_up / max_network_speeds.up > 0.8 { |
Collaborator
There was a problem hiding this comment.
Perhaps break this 0.8 out into a named variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there 👋,
thanks for the awesome bar, I am using it for quite some time and I happy with it :-)
Regarding, the network graph, for me, the current implementation is not very intuitive. The main reason is that it is relative and the base is constantly changing. I am usually interested in the network load in relation to my network capability, such that a bit "more" noise does not show up as spikes.
This PR adds the capability to define your network up and down speed. I am using this implementation on my site for quite some time already. It works stable and reliable on my site.
I am open for discussion, because although this is much more intuitive to me, it does not have to be the case for everyone. I still believe that for most users, it will be more intuitive. Let's discuss improvements / alternatives if you don't agree.
Here is an example:
The result would be:
graph_downshows 50% of full bar (not 100% due to spike)