Adds ethanol for ALPB #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you so much for xTB developers for developing and maintaining the xTB code!
This PR is a follow-up of #127. I found that ALPB
ethanolis actually available in xTB with e.g.xtb benzene.xyz --alpb ethanol. I confirmed this with actual calculations (ALPB.zip) as well as with the following source codes:https://github.com/grimme-lab/xtb/blob/d3f212ba83287290efafee6580670d02d7b2f49d/src/solv/model.f90#L147
https://github.com/grimme-lab/xtb/blob/d3f212ba83287290efafee6580670d02d7b2f49d/src/solv/model.f90#L351
https://github.com/grimme-lab/xtb/blob/d3f212ba83287290efafee6580670d02d7b2f49d/src/solv/model.f90#L378
https://github.com/grimme-lab/xtb/blob/d3f212ba83287290efafee6580670d02d7b2f49d/src/solv/model.f90#L408
The
ethanolis however not documented on the website, which will hopefully be fixed with the present PR.