Skip to content

refactor(ui): use paginated author query for metadata autocomplete - #2366

Open
alexhb1 wants to merge 1 commit into
refactor/frontend-author-browsefrom
author-paginated-autocomplete
Open

refactor(ui): use paginated author query for metadata autocomplete#2366
alexhb1 wants to merge 1 commit into
refactor/frontend-author-browsefrom
author-paginated-autocomplete

Conversation

@alexhb1

@alexhb1 alexhb1 commented Aug 14, 2026

Copy link
Copy Markdown
Member

Description

Swaps the p-autocomplete components used for author input to use the author query service and paginated / lazy loaded results.

Linked Issue

N/A

Changes

  • author-autocomplete.service.ts handling the basic pagination/loading in the shape that the p-autocomplete component needs
  • Wired up to the metadata editor, physical book dialog, metadata picker, and bulk editor dialog, replacing the client side computed list.

Manual Testing Steps

Use components, confirm results are complete, lazy loaded, and choosing an author correctly fills and matches with the rest of the FE browsing UI.

Screenshots (Optional)

N/A

Additional Context (Optional)

This is for the optimus p-autocomplete and current UI. Not supported with the native app-autocomplete until metadata page reworks can take place.

AI Disclosure

N/A

Checklist

  • This PR links and implements an accepted issue.
  • This PR is a single focused change.
  • There are new or updated tests validating this change.
  • I ran just ui check and just api check.
  • I have added screenshots if there were any UI changes.
  • I have disclosed any AI usage as per the organization AI Policy above.
  • I understand all of my submitted changes.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: 56c6489e-d285-4e61-bbe4-e1a6f12b1f01

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alexhb1

alexhb1 commented Aug 14, 2026

Copy link
Copy Markdown
Member Author

Sonar doesn't like the duplicated HTML for each p-autocomplete, but extracting that would be weird, so i think it's fine.

@alexhb1
alexhb1 requested a review from zachyale August 15, 2026 07:40
@alexhb1
alexhb1 force-pushed the author-paginated-autocomplete branch from a92962b to 591e3ea Compare September 3, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant