refactor(epub): make epub extraction / creation code reusable - #2629
Draft
imnotjames wants to merge 1 commit into
Draft
refactor(epub): make epub extraction / creation code reusable#2629imnotjames wants to merge 1 commit into
imnotjames wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
imnotjames
force-pushed
the
refactor/2001/make-code-reusable-epub-reader-writer
branch
from
September 14, 2026 04:26
171492b to
dd1af2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The epub metadata writer has a function that creates an epub from a directory, to extract an epub to a directory using archive service, and a helper to find the OPF path. All three of these are useful in other places, so this extracts them to the archive service, epub content reader, and a new epub content writer utility class.
Linked Issue
related to #2001
Changes
ArchiveService.extractToDirectoryhelperEpubContentReader.findOPFInExtractedEpubEpubContentWriter.createEpubFromDirectoryEpubMetadataWriterto use these helpersCBXConversionServiceto use helper extract helperManual Testing Steps
Screenshots (Optional)
Additional Context (Optional)
AI Disclosure
Checklist
just ui checkandjust api check.