Checkbox added to grid options to show/hide "equal sign" or formula icons #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd + / or click outside the popup window for it to hide again.
…restored and reomved some comments as requested, and code adjustments as requested. Added onClickOutside function to domUtils.ts to dismiss the help window. Restored DocApiTypes-ti.ts as it was unrelated to this request.
…cons can only be hidden in table view, reappear when the field is edited.
… path for onClickOutside.
…formatting changes.
…a cell/field, and renamed the fieldIcon property to formulaIcon for clarity (as there is already a field-icon class).
…omehow. Hopefully this is fixes it.
Contributor
|
Deployed commit |
|
Looking forward to seeing this land! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Added the ability to show/hide the formula icons in the table widget view under "Grid Options". While the formula icon is very handy when creating, setting up, and editing tables, it can take up considerable screen space. This option allows the user to hide the icons when desired to improve table layout.
Proposed solution
I added a checkbox under the "Grid Options", which is available for table widgets. The checkbox is activated by default to conform with the default app behaviour. So it will default to showing the formula icon (or "="). The end user can deselect the checkbox to hide the formula icons, providing additional space for their data to be displayed.
The checkbox added under "Grid Options". It triggers a css class to be added to the 'field-icon' div. The new class (record-icon) controls the "=" (formula icon) when it is within a formula field. A new class was created so that the field-icon class could be still be used for icons in non formula fields. The CSS was updated to use the new class, and adjust for some class changes that occur when a the editor to the "Expand Editor".
Related issues
Related to #1365
Has this been tested?
I added a test to the GridOptions.ntest.js, but this is the first time I've added a test. I followed the existing structure of the file but please check that I did it right.
Screenshots / Screencasts
Showing two tables with formula-icons and two without.
