Skip to content

Conversation

@David-Guillot
Copy link

Hi @berhalak , @dsagal ,

The goal of this PR is not only to fix #4 , it's also to make contributing easier and restore trust of the community into this lib (probably also closing #5 ).

As you can see, the Github CI is passing for all currently supported Python versions, and modern tooling has been setup. The only thing I was not able to test is packaging/distribution, but it should work out-of-the box as I just copy/pasted some configuration from other projects.

This is of course only the beginning, as something could also be done with ruff, setting up a CONTRIBUTING.md file, more docs...

Let me know what you think about it!

@berhalak berhalak self-assigned this Apr 1, 2025
@dsagal
Copy link
Member

dsagal commented Aug 17, 2025

Hi @David-Guillot, this is excellent, thank you for doing this, and apologies for taking so long to get to this. @berhalak, I feel this can be landed as is, and then we'll probably want to follow up with some cleanup. I am thinking:

  • Update README.md to document new test/build/publish instructions (we could drop justfile then, and probably drop twine as well since uv can do that job).
  • Publish the new version.
  • Look into modernizing (or at least updating) generated documentation.
  • Other things @David-Guillot mentioned (ruff for linting, CONTRIBUTING.md, more docs)

@berhalak berhalak self-requested a review September 10, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lib broken on Python 3.12

3 participants