Performance improvements #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing strategy caused each matching font-awesome substitution to cause two separate DOM calls (one to read, one to write). The new strategy uses regex and makes only a single replacement for the whole document.
Using @import has performance penalties as normalize cannot be requested until screen has already been loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on adding some performance improvements to GhostScroll over the last few days and thought some or all of them might be appreciated upstream. This PR functions almost identically to the base version, but has a few changes:
{{navigation}}so the user does not need to ever modify the theme directly.If some subset of these changes (for example: not the build step) would be of interest, please let me know and I'd be happy to oblige.