New Feature: checkout assets to locations based on buildings in JAMF#141
Draft
jbagot wants to merge 1 commit intogrokability:mainfrom
Draft
New Feature: checkout assets to locations based on buildings in JAMF#141jbagot wants to merge 1 commit intogrokability:mainfrom
jbagot wants to merge 1 commit intogrokability:mainfrom
Conversation
Member
|
@jbagot Thanks for working on this! I know it's still a WIP, but I'd like to request that you pull-out the formatting changes, and submit those as a separate PR, so we can evaluate your functional changes separately from the diff so long that github won't display it by default ;) |
e30cf84 to
9dfd651
Compare
Author
|
Done, now there is only the feature, I removed the format commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new feature that sync the jamf buildings to snipe. It works fine if the locations are created in snipe it, but there are some work to do.
Things to do
The PR has 2 commits, one for commit and other with the new feature. The format is an automatic format of Black.