Skip to content

[visual-qa] Ctrl-right-click delete on CIRCULARSTRING leaves a phantom point #97

Description

@grootstebozewolf

Witness (RC3)

Move/add/delete vertex tool. Ctrl-right-click a control on a CIRCULARSTRING (or a GEOMETRYCOLLECTION of them) does delete the vertex, but a phantom point stays on the canvas.

Screenshot: Screenshot 2026-08-22 140117.png.

Why

  1. Even leftover. Insert ([visual-qa] EditVertex right-click add vertex on CIRCULARSTRING makes even control count #82 / PR fix: EditVertex right-click add on CIRCULARSTRING keeps odd control count #83) adds +2 so the control count stays odd. Delete still removes one coordinate (GeometryVertexDeleter). A 5-control CS becomes 4. The renderer walks triples (0,1,2), (2,3,4), …; the even leftover is drawn as a dangling vertex / chord that is not an arc — the phantom.
  2. XOR indicator. EditVertexTool.mouseClicked (right-click insert/delete) never clearIndicator(). A prior left-press draws the rubber-band circle in XOR; right-click mouseReleased returns without clearing it, so the circle stays at the deleted vertex.

Not HotPixel. Same tool path as #82, inverse operation.

Expected

  • Ctrl-right-click delete on a CircularString removes two controls (the vertex and its paired mid), count stays odd and ≥ 3.
  • 3-control CS refuses delete (would drop below a single arc).
  • No leftover vertex in the WKT; no XOR circle after the click.
  • GeometryCollection wrapper kept.

Do not close without UX SIGN.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions