Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a player login system for a Velocity proxy plugin, replacing a basic Java implementation with a comprehensive Kotlin-based solution that integrates with a gRPC player presence service.
Changes:
- Migrated main plugin class from Java to Kotlin with proper dependency injection and lifecycle management
- Implemented gRPC-based player presence service for login/logout operations with error handling
- Added configurable user-facing messages via YAML configuration
- Refactored build system to use shared convention plugins
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| velocity/src/main/kotlin/gg/grounds/GroundsPluginPlayer.kt | New main plugin class with gRPC client configuration and event listener registration |
| velocity/src/main/kotlin/gg/grounds/presence/PlayerPresenceService.kt | Service wrapper for gRPC player presence client with error handling |
| velocity/src/main/kotlin/gg/grounds/listener/PlayerConnectionListener.kt | Event handlers for player login and disconnect with presence service integration |
| velocity/src/main/kotlin/gg/grounds/config/MessagesConfigLoader.kt | YAML-based configuration loader for user-facing messages |
| velocity/src/main/kotlin/gg/grounds/config/MessagesConfig.kt | Data class for message configuration with defaults |
| velocity/src/main/resources/messages.yml | Default message templates for login errors |
| common/src/main/kotlin/gg/grounds/player/presence/GrpcPlayerPresenceClient.kt | gRPC client implementation with timeout handling and graceful shutdown |
| common/src/main/kotlin/gg/grounds/player/presence/PlayerLoginResult.kt | Sealed class for representing login operation results |
| velocity/src/main/java/gg/grounds/GroundsPluginPlayer.java | Removed basic Java implementation in favor of new Kotlin version |
| velocity/build.gradle.kts | Simplified to use convention plugins and added Jackson/gRPC dependencies |
| common/build.gradle.kts | New build configuration with protobuf plugin and gRPC dependencies |
| build.gradle.kts | Simplified to use shared base conventions plugin |
| settings.gradle.kts | Updated project name and added GitHub package repository configuration |
| velocity/devspace.yaml | Updated for new development workflow with plugin synchronization |
| README.md | Added configuration documentation for gRPC target and messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
velocity/src/main/kotlin/gg/grounds/presence/PlayerPresenceService.kt
Outdated
Show resolved
Hide resolved
12 tasks
ItsKev
requested changes
Jan 19, 2026
ItsKev
approved these changes
Jan 19, 2026
lusu007
added a commit
that referenced
this pull request
Jan 19, 2026
* feat: implement player login * chore: update gradle plugin to conventions plugin * refactor: remove lots of duplicated code which is already present from player.proto * fix: align plugin name to naming conventions * fix: Register missing providers manually * fix: use full kubernetes url * fix: improve error handling * feat: use envs for configuring plugin * feat: use grpc-conventions plugin --------- Co-authored-by: ItsKev <kevin.huber@hotmail.com>
lusu007
added a commit
that referenced
this pull request
Jan 19, 2026
* feat: implement player login * chore: update gradle plugin to conventions plugin * refactor: remove lots of duplicated code which is already present from player.proto * fix: align plugin name to naming conventions * fix: Register missing providers manually * fix: use full kubernetes url * fix: improve error handling * feat: use envs for configuring plugin * feat: use grpc-conventions plugin --------- Co-authored-by: ItsKev <kevin.huber@hotmail.com>
ItsKev
added a commit
that referenced
this pull request
Jan 19, 2026
* feat: add player login (#5) * feat: implement player login * chore: update gradle plugin to conventions plugin * refactor: remove lots of duplicated code which is already present from player.proto * fix: align plugin name to naming conventions * fix: Register missing providers manually * fix: use full kubernetes url * fix: improve error handling * feat: use envs for configuring plugin * feat: use grpc-conventions plugin --------- Co-authored-by: ItsKev <kevin.huber@hotmail.com> * chore: use reusable workflow --------- Co-authored-by: ItsKev <kevin.huber@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Implements proper player login.
Type of Change
Related Issues
None
Testing
Checklist