-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suppressions for GuardedBy violations #6566
Merged
dapengzhang0
merged 7 commits into
grpc:master
from
graememorgan:guardedby-suppressions
Dec 30, 2019
Merged
Add suppressions for GuardedBy violations #6566
dapengzhang0
merged 7 commits into
grpc:master
from
graememorgan:guardedby-suppressions
Dec 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran-su
approved these changes
Dec 23, 2019
@garrettjonesgoogle There might be more need to suppress /git/grpc-java/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java:433: error: [GuardedBy] This access should be guarded by 'stream.transportState().lock'; instead found: 'this.lock'
stream.transportState().start(nextStreamId);
^
(see https://errorprone.info/bugpattern/GuardedBy)
/git/grpc-java/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java:1139: error: [GuardedBy] This access should be guarded by 'stream.transportState().lock'; instead found: 'OkHttpClientTransport.this.lock'
stream.transportState().transportDataReceived(buf, inFinished);
^
(see https://errorprone.info/bugpattern/GuardedBy)
/git/grpc-java/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java:1189: error: [GuardedBy] This access should be guarded by 'stream.transportState().lock'; instead found: 'OkHttpClientTransport.this.lock'
stream.transportState().transportHeadersReceived(headerBlock, inFinished);
^
(see https://errorprone.info/bugpattern/GuardedBy)
/git/grpc-java/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java:263: error: [GuardedBy] This access should be guarded by 'OkHttpClientStream.this.state.lock'; instead found: 'this.lock'
state.onStreamAllocated();
^
(see https://errorprone.info/bugpattern/GuardedBy)
/git/grpc-java/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java:376: error: [GuardedBy] This access should be guarded by 'this.transport.lock'; instead found: 'this.lock'
transport.removePendingStream(OkHttpClientStream.this);
^
(see https://errorprone.info/bugpattern/GuardedBy)
/git/grpc-java/okhttp/src/main/java/io/grpc/okhttp/OkHttpClientStream.java:419: error: [GuardedBy] This access should be guarded by 'this.transport.lock'; instead found: 'this.lock'
transport.streamReadyToStart(OkHttpClientStream.this);
^
(see https://errorprone.info/bugpattern/GuardedBy)
|
You're quite right. Done. |
Note for myself: Once this PR is merged to master, I'll check #6574. |
ejona86
approved these changes
Dec 30, 2019
I've filed #6578 for us to try to clean up the suppressions. |
dapengzhang0
approved these changes
Dec 30, 2019
@graememorgan Thanks for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports releasing a new version of GuardedBy which finds more mistakes than it used to.