all: Add suppressions for GuardedBy violations to v1.24.x to fix Bazel rules_grpc in Bazel 3.4.1 #7291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports releasing a new version of GuardedBy which finds more mistakes than it used to. Filed grpc#6578 to try to clean up the suppressions.
rickwebiii
changed the title
dapengzhang0
approved these changes
Aug 10, 2020
dapengzhang0
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java GRPC Bazel rules in
rule_proto_grpcfail with Bazel 3.4.1 due to GuardedBy errorprone rule. Cherry pick the fix.This supports releasing a new version of GuardedBy which finds more mistakes than it used to.
Filed
#6578#7297 to try to clean up the suppressions.