Fix file paths in generated source jars #503
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Author
|
Apologies, accidentally pushed an unrelated commit to the PR branch. Fixed now. |
Collaborator
|
Can you give an example before and after this CL? Also it's quite a long time so the tests couldn't run anymore. I can rebase to retrigger the tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Bazel zipper to generate the source jar, the entire path starting from bazel-out is sent to the ijar tool, which becomes the paths to the source files inside the generated jar. To remove this unnecessary prefix and produce source jars with directory structure matching standard Java source jars, we can use the dest=src argument style for the ijar tool, using each file's relative paths as the dest part. This produces source jars with the expected directory structure.