Skip to content

changes for build modification and protoc-plugin #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kumarakshays
Copy link

fixes-#1449

Copy link

CLA Missing ID CLA Not Signed

@sampajano
Copy link
Collaborator

Thanks for the change, @kumarakshays!

This is on the right track!!

Although, one error we need to address is following:

ERROR - [JSC_READ_ERROR] Cannot read file ../../third_party/protobuf/js: ../../third_party/protobuf/js

This is because javascript has been removed from newer protobuf repo, so we need to migrate our protobuf JS dependency to https://github.com/protocolbuffers/protobuf-javascript too. (see #1449 (comment))

However we can probably find a way to decouple that by keeping the JS dependency (e.g. rename it to /thirdparty/protobuf-old/ and keep the 3.15.6 version) and fix the c++ compilation first using this change.

@kumarakshays
Copy link
Author

Thank you,@sampajano
Once the C++ compilation is fixed, I can create a follow-up PR to migrate the JS dependency to protobuf-javascript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants