Add setup instructions for GA and GTM to README #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
suggested changes
Jul 24, 2024
|
Seems like #1332 (review) still needs to be resolved, so holding off on merging for now. |
@Gayathri625 For reference, this seems to be the block that only includes analytics scripts when in production mode: https://github.com/grpc/grpc.io-docsy/blob/ba20af1c9044e3ad8d83ead5153b243c88539038/layouts/partials/head.html#L55-L61 |
|
I see that we load GTM scripts in non-prod also in #1313. Can you have a similar prod env check for them also? You can do that in a separate PR. |
gnossen
approved these changes
Jul 29, 2024
dfawley
pushed a commit
to dfawley/grpc.io
that referenced
this pull request
Sep 10, 2024
* add setup for ga and gtm to readme * instruction to set hugo env to production * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README.md to include setup and verification instructions for Google Analytics and Google Tag Manager.