add support for cloud-nuke-excluded tag in Cloudtrail resource #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james03160927
approved these changes
Feb 24, 2025
|
Hi @ErezWeiss, did you test your change? I'm seeing this error during build time. |
james03160927
requested changes
Feb 24, 2025
wakeful
reviewed
Feb 25, 2025
| @@ -23,6 +23,7 @@ func (ct *CloudtrailTrail) getAll(c context.Context, configObj config.Config) ([ | |||
| for _, trailInfo := range page.Trails { | |||
| if configObj.CloudtrailTrail.ShouldInclude(config.ResourceValue{ | |||
| Name: trailInfo.Name, | |||
| Tags: util.ConvertTypesTagsToMap(trailInfo.Tags), | |||
There was a problem hiding this comment.
The resource you are iterating over lacks the 'Tags' field. You need to call this method for each resource first.
|
Friendly ping @ErezWeiss . |
@james03160927 thanks for that, hopefully I'll handle it in the upcoming weeks |
|
Got it. SGTM. Thanks |
|
Friendly ping @ErezWeiss |
|
HI @ErezWeiss, friendly ping. Do you plan to continue working on this change? |
|
I'll take over the change and merge it in! 👍 since we haven't heard back from you for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for cloud-nuke-excluded tag in Cloudtrail resource
missing test, need some help here