Improve text rendering performance, closes #2478, closes #2515 #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
harshad1
changed the title
harshad1
commented
Feb 6, 2025
harshad1
commented
Feb 6, 2025
harshad1
commented
Feb 6, 2025
app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserListAdapter.java
Show resolved
Hide resolved
harshad1
commented
Feb 6, 2025
harshad1
commented
Feb 6, 2025
| @@ -929,4 +929,14 @@ public FileVisitResult visitFile(final Path path, final BasicFileAttributes attr | |||
| } | |||
| return null; | |||
| } | |||
|
|
|||
| public static String getPath(final File file) { | |||
There was a problem hiding this comment.
Moved here from Document
harshad1
commented
Feb 6, 2025
|
@gsantner This is ready |
|
Thank you very much! I tried the changes and it looked way faster overall! The cursor seems a bit..jumpy...when you open a document, though I might be wrong and noticed that before. I will be merging this, thanks! |
gsantner
approved these changes
Mar 11, 2025
4 tasks
gsantner
changed the title
4 tasks
Hmm. I will keep an eye out for that. If you find a way to reproduce it, please share and I will investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we reorganise view / edit mode a little.
This fixes:
Also addresses #2515