Enable consent or pay banner #13199
Merged
Enable consent or pay banner #13199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.22 kB (+0.14%) Total Size: 899 kB
ℹ️ View Unchanged
|
tomrf1
commented
Jan 27, 2025
| @@ -41,7 +41,6 @@ export type SignedInWithOkta = { | |||
| }; | |||
|
|
|||
| export type AuthStatus = | |||
| | { kind: 'Pending' } | |||
There was a problem hiding this comment.
this state is only relevant in the useAuthStatus hook, where we initialise the value as "Pending" and set it asynchronously
rupertbates
reviewed
Jan 28, 2025
| // We must first allow reject all | ||
| const expires = new Date(); | ||
| expires.setMonth(expires.getMonth() + 6); | ||
| await addCookie(context, { |
There was a problem hiding this comment.
Use the setAllowRejectAllCookie function in allowRejectAll.ts instead of reproducing the logic
There was a problem hiding this comment.
unfortunately this is quite playwright-specific (it uses a BrowserContext object to set cookies)
rupertbates
reviewed
Jan 28, 2025
dotcom-rendering/src/client/userFeatures/cookies/allowRejectAll.ts
Outdated
Show resolved
Hide resolved
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
dotcom-rendering/package.json
Outdated
| @@ -47,7 +47,7 @@ | |||
| "@guardian/eslint-config-typescript": "9.0.1", | |||
| "@guardian/identity-auth": "2.1.0", | |||
| "@guardian/identity-auth-frontend": "4.0.0", | |||
| "@guardian/libs": "20.0.0", | |||
| "@guardian/libs": "21.0.1", | |||
There was a problem hiding this comment.
There's a new version 21.1.0
|
@akinsola-guardian @tomrf1 as discussed I have a concern that new network requests to the members data API and within Sourcepoint, before we init CMP will mean a delay to consent state being provided to the app. This could in theory introduce a meaningful delay to the app initialising, commercial loading and ads being rendered and therefore a CWV and revenue impact. I appreciate this is unavoidable with the current implementation, but we should track I have verified that |
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (created by @tomrf1 and merged by @akinsola-guardian 7 minutes and 44 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the new version of the cmp library which supports "consent or pay".
This means we now pass in two new parameters when initialising cmp with
cmp.init.These are:
useNonAdvertisedList- used to decide whether to show the reduced "non-advertised" list to users with the "reject all" benefit,isUserSignedIn- used to decide whether or not to display the sign-in cta.This change takes place in the initialisation script, not a react component. We're adding a new
awaitwhich may trigger a network call to Okta, to find out if the user is signed in. In practice this may mean that the consent banner takes longer to render. But it's important we have the correct value to avoid e.g. showing a sign-in link to a user who has just signed in.I've also done a small refactor of the
AuthStatustype to simplify handling of the result of thegetAuthStatusfunction. PreviouslyAuthStatuscould potentially be{ kind: 'Pending' }. However, this is only relevant to theuseAuthStatushook, so I've moved it there.