Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost of Pay, because of excluded collection, should trump Overquota #4418

Closed
wants to merge 2 commits into from

Conversation

paperboyo
Copy link
Contributor

Co-authored by Copilot 🙀🔫🤖.

What does this change?

We have a concept of Excluded Collections (based on source field) where images are Paid, even if their Supplier is Free. Currently, when such a Supplier runs over quota, users are unable to see those images as Paid, they can only see they are Overquota (Overquota badge instead of a £ one). Paid is a stronger signal (ie. should be leased less lightly) than Overquota, so they are asking for it to trump it.
This PR makes that change.

How should a reviewer test this change?

  • Configure a Free supplier to run over quota
  • Upload two images from this Supplier (or edit existing ones), so that one of them is from the Excluded Collection (currently, only Getty)
  • notice how badges and Usage Rights notices in Viewer differ with this PR: a pound badge is clearly displayed for an image from an Excluded Collection

How can success be measured?

Hopefully, users will not lease Paid images as lightly as Overquota ones

Who should look at this?

Tested? Documented?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment
  • relevant documentation added or amended (if needed)

@paperboyo paperboyo changed the title Cost of Pay, because of excluded collection, should trump Overquota Cost of Pay, because of excluded collection, should trump Overquota Feb 15, 2025
@paperboyo
Copy link
Contributor Author

paperboyo commented Feb 19, 2025

Sorry ChatNFT, but closing this in favour of your human overlords in #4420. If you would want my advice, learn how to say “I don’t know”. And see you next century.

@paperboyo paperboyo closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant