Use purchases.subscriptionsv2 for Android Feast subscriptions #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjmw
force-pushed
the
tw/v2-feast-android-subscription-purchase-endpoint
branch
from
ac2873c
to
795e9aa
Compare
Base automatically changed from
tw/parse-obfuscated-account-id-from-google-response
to
main
June 10, 2024 08:21
tjmw
force-pushed
the
tw/v2-feast-android-subscription-purchase-endpoint
branch
from
795e9aa
to
1b0bc21
Compare
tjmw
changed the title
tjmw
commented
Jun 10, 2024
| const promises = event.Records.map(async (sqsRecord: SQSRecord) => { | ||
| try { | ||
| const subscriptions = await fetchSubscriptionDetails(sqsRecord); // Subscription[] | ||
| await Promise.all(subscriptions.map(sub => putSubscription(sub))); | ||
| // TODO: parse this using zod to get validation |
There was a problem hiding this comment.
This TODO is for a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Use the
purchases.subscriptionsv2endpoint to retrieve data about Android Feast subs, instead ofpurchases.subscriptionsv1 (which we use for the live app).The reason for the migration is that when using the v1 endpoint, we rely on being able to map a product ID to a billing duration. This mapping is defined here:
mobile-purchases/typescript/src/services/productBillingPeriod.ts
Line 4 in bb1632e
Some back story on the v2 endpont: Tom Wadeson did some work to implement the v2 endpoint. In product there's a test which uses the v2 endpoint in parallel with the v1 endpoint for x% of requests to the subscriptions endpoint. There's a draft PR #1338 to use the new libs everywhere, but not merged yet. Using this for Feast feels like a nice step in the migration path as we're using it for real but in a focused context.
How to test
I've updated the Jest tests and tested in CODE (and can now see the billing duration being correctly set).
How can we measure success?
Have we considered potential risks?
Images
Accessibility