Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feed card layout tweaks #169

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feed card layout tweaks #169

wants to merge 2 commits into from
+66 −38

Conversation

bryophyta
Copy link
Contributor

@bryophyta bryophyta commented Feb 21, 2025 •
edited
Loading

What does this change?

  • Fix a bug in the wire feed card layout, whereby the time stamp was being pushed down to the bottom of the card if the date was also showing (i.e. when it wasn't today's date)
  • Move the supplier badge to the right hand side, under the date, to de-emphasise
  • Fix a regression whereby the main heading wasn't being rendered in bolder text anymore
  • When we have a search highlight to show, don't render other secondary content.

How to test

How can we measure success?

Have we considered potential risks?

Images

Before After
image image
image image

Accessibility

@github-actions GitHub Actions
Copy link

Deploy build 801 of Editorial Tools::News Wires to CODE

All deployment options

From guardian/actions-riff-raff.

@bryophyta bryophyta marked this pull request as ready for review February 21, 2025 11:23
@bryophyta bryophyta requested a review from a team as a code owner February 21, 2025 11:23
@bryophyta bryophyta changed the title Pf/fix date time separation Feed card layout tweaks Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bryophyta