fix(prisma): Correct volume permissions #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the order of deployments for correctness. Co-authored-by: Julia <[email protected]> Co-authored-by: Natasha <[email protected]>
To increase determinism, use full file paths. By not using relative paths, we remove the need for the working directory to be correct. Co-authored-by: Julia <[email protected]> Co-authored-by: Natasha <[email protected]>
Update AWS infrastructure, creating a volume at `/usr/src/app/prisma`, and download the S3 artifact to this directory. Co-authored-by: Julia <[email protected]> Co-authored-by: Natasha <[email protected]>
akash1810
force-pushed
the
mob/prisma-prisma-prisma
branch
from
ea0e405 to
e3b7e59
Compare
akash1810
changed the title
akash1810
commented
May 13, 2024
|
|
||
| COPY ./containers/prisma-migrate/run-prisma-migrate.sh ./run-prisma-migrate.sh | ||
| RUN chmod +x ./run-prisma-migrate.sh | ||
| COPY ./containers/prisma-migrate/run-prisma-migrate.sh /usr/src/app/run-prisma-migrate.sh |
There was a problem hiding this comment.
Using the full file path isn't strictly necessary as WORKDIR is set above. However, it makes it easier to understand exactly what is being done.
JuliaBrigitte
approved these changes
May 13, 2024
akash1810
commented
May 13, 2024
| const prismaVolume: Volume = { | ||
| name: 'prisma-volume', | ||
| const prismaArtifactVolume: Volume = { | ||
| name: 'artifact-volume', |
There was a problem hiding this comment.
Renamed to "artifact" to distinguish this from the location the prisma binary is installed; "artifact" also matches the language used in other applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #986 the Prisma migration task has been failing with:
That is, we're unable to download a file from S3 to a read-only path.
What does this change, and why?
This change:
/usr/src/app/prismavolume in the container, as a writable locationThis results in the above error being resolved, and the migrations completing. Indeed the logs show this:
An additional change was made to better orchestrate the deployment order. See the inline comment for more detail.
How has it been verified?
The updated container was deployed to, and ran on, CODE. See the above screenshot for the logs.
Co-authored-by: @JuliaBrigitte
Co-authored-by: @NovemberTang