Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max one-off contribution by 4 percent #6520

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewHEguardian
Copy link
Contributor

What are you doing in this PR?

Increasing the maximum allowed one-off contribution by 4% to allow people to use the "cover transaction cost" checkbox on the highest contributions.

Trello Card

Why are you doing this?

We've seen alarms since adding the checkbox (#6277) that people went over the maximum! This is because the client did not validate the maximum after the additional 4% added by the checkbox. This maximum amount is not a legal / tax decision and is just reputational, so adding 4% is OK.

How to test

I pointed the payment-api to local and ran it there with the changes. Then in the UK made a one off contribution of £1991 plus the checkbox

Screenshots

Before
image
After
image

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Size Change: 0 B

Total Size: 2.23 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 112 kB
./public/compiled-assets/javascripts/[countryGroupId]/router.js 255 kB
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 234 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 69.3 kB
./public/compiled-assets/javascripts/error404Page.js 69.3 kB
./public/compiled-assets/javascripts/error500Page.js 69.2 kB
./public/compiled-assets/javascripts/favicons.js 617 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 174 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 86 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 67.5 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 72.2 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 71.5 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 126 kB
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 306 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 171 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 85.8 kB
./public/compiled-assets/webpack/136.js 2.17 kB
./public/compiled-assets/webpack/187.js 21.4 kB
./public/compiled-assets/webpack/344.js 2.01 kB
./public/compiled-assets/webpack/689.js 21.6 kB
./public/compiled-assets/webpack/706.js 107 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant