Open
Conversation
neoblizz
reviewed
Nov 7, 2023
Comment on lines
+12
to
+13
| // Allocate memory for the host matrix data | ||
| h_C.m_data.resize(d_C.rows * d_C.cols); |
Member
There was a problem hiding this comment.
You can see it here, what is the size of d_C.rows * d_C.cols? I think this is
neoblizz
reviewed
Nov 7, 2023
| h_C.m_data.resize(d_C.rows * d_C.cols); | ||
|
|
||
| // Copy matrix data from device to host | ||
| cudaMemcpy(h_C.m_data.data(), d_C.m_data_ptr, sizeof(type_t) * d_C.rows * d_C.cols, cudaMemcpyDeviceToHost); |
neoblizz
reviewed
Nov 7, 2023
| csc_t<index_t, offset_t, type_t> csc(mtx.load(parameters.filename)); | ||
|
|
||
| // Output matrix. | ||
| matrix_t<type_t> C(csr.rows, csc.cols); |
… and a column of B per thread with the stride size of TILE_SIZE
Member
|
@Floruaaa666 I see that this is a work in progress, let me know when you'd like me to review for merge after its been cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My SpGEMM approach uses the inner product (CSR*CSC = dense format) and I used a few input matrices from SS to test. For some of the input matrices, the program had an error saying:
The matrices with this error: