Skip to content

Conversation

@charisoudis
Copy link

When filesize is greater than 4Mib, write fails without a notice, i.e. returning true.
This PR, implements writeStream method and update write to use it when the file size exceeds that threshold.

Code heavily inspired by:
shitware-ltd/flysystem-msgraph

Author:
Thanos Charisoudis
[email protected]
Eurotechnik Charisoudis
eurotechnik.gr

* use chunking when filesize greater than 4Mib
@mortenscheel
Copy link

Your PR includes a call to $this->getFileBaseUrl() which doesn't exist. I borrowed your changes and got it to work by replacing that line with

return \sprintf('/v1.0/drives/%s/items/%s:/%s', $this->getConnector()->getDrive()->getDriveId(), $parentFolderId, $fileName)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants