Skip to content

fix lto-type-mismatch between declarations #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

caveman99
Copy link

.pio/libdeps/tbeam/NimBLE-Arduino/src/nimble/nimble/host/src/ble_gap.c:7944:16: warning: type of 'is_ble_hs_resolv_enabled' does not match original declaration [-Wlto-type-mismatch]
     extern int is_ble_hs_resolv_enabled(void);
                ^
.pio/libdeps/tbeam/NimBLE-Arduino/src/nimble/nimble/host/src/ble_hs_resolv.c:331:1: note: return value type mismatch
 is_ble_hs_resolv_enabled(void)
 ^
.pio/libdeps/tbeam/NimBLE-Arduino/src/nimble/nimble/host/src/ble_hs_resolv.c:331:1: note: type 'uint8_t' should match type 'int'
.pio/libdeps/tbeam/NimBLE-Arduino/src/nimble/nimble/host/src/ble_hs_resolv.c:331:1: note: 'is_ble_hs_resolv_enabled' was previously declared here
.pio/libdeps/tbeam/Crypto/AESEsp32.cpp:33:5: warning: type of 'esp_aes_setkey' does not match original declaration [-Wlto-type-mismatch]

@h2zero
Copy link
Owner

h2zero commented Apr 12, 2025

Thank you @caveman99. I haven't seen this warning before, can you share your environment settings?

The issue with merging this is that it is not mirrored upstream: https://github.com/espressif/esp-nimble/blob/70439dd17c4754964bf6c99b8e27c94ac32bccae/nimble/host/src/ble_gap.c#L9437

I aim to minimize the differences between this and the upstream code as much as possible, only fixing what is required for the purpose here.

@h2zero
Copy link
Owner

h2zero commented Apr 22, 2025

Thanks @caveman99, I just merged nimble core 1.6 so this may no longer be an issue. Please open a new PR against the current master if so.

@h2zero h2zero closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants