Skip to content

[BUGFIX] Avoid undefined array key when determining strategy - #25

Open
brotkrueml wants to merge 3 commits into
haassie:masterfrom
brotkrueml:strategy-undef-array-key
Open

[BUGFIX] Avoid undefined array key when determining strategy#25
brotkrueml wants to merge 3 commits into
haassie:masterfrom
brotkrueml:strategy-undef-array-key

Conversation

@brotkrueml

Copy link
Copy Markdown

Resolves: #24

@PhilippKuhlmay

Copy link
Copy Markdown

Hi @brotkrueml
I get the same Error inside /page_speed_insights/Classes/FormEngine/Elements/History.php:48 when trying to edit the pagesettings of a page.
After changing this line into $this->strategyToShow = ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['page_speed_insights']['strategyToShow'] ?? '') ?: 'mobile'; the error disappeared. So this line should be changed too. Thanks.

@brotkrueml brotkrueml changed the title [BUGFIX] Avoid undefined array key in DrawHeaderHook [BUGFIX] Avoid undefined array key when determining strategy Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP 8.0: PHP Warning: Undefined array key "strategyToShow"

2 participants